Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clojure.org/data.json, because cljs removed it #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

transducer
Copy link

@transducer transducer commented Aug 26, 2022

The dependency org.clojure/data.json was removed from ClojureScript in
version 1.11.51 of May 13th 2022. See release notes:

Vendorization of tools.reader, data.json, and transit-clj
(...)
After conferring with the Clojure Team, we decided to vendorize all
these dependencies. This way we can AOT everything and be confident
that we won’t create a conflict that can’t easily be fixed via
normal dependency management. (...) The dependance on data.json has
been removed

This PR adds an explicit dependency on clojure.data.json.

Fixes #98

The dependency org.clojure/data.json was removed from ClojureScript in
version 1.11.51 of May 13th 2022. See release notes
https://clojurescript.org/news/2022-05-13-release:

Vendorization of tools.reader, data.json, and transit-clj
(...)
    After conferring with the Clojure Team, we decided to vendorize all
    these dependencies. This way we can AOT everything and be confident
    that we won’t create a conflict that can’t easily be fixed via
    normal dependency management. (...) The dependance on data.json has
    been removed

This commit adds an explicit dependency on clojure.data.json.

Fixes binaryage#98
@ashneo76
Copy link

This fix works for me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants